TPT-4456: Project RDMA Linode Interfaces by yec-akamai · Pull Request #736 · linode/linode_api4-python

yec-akamai · 2026-09-02T15:59:24Z

📝 Description

Merge project rdma interfaces into dev.

✔️ How to Test

make test-unit

To run the integration test, you will need to enable it with export RUN_RDMA_TESTS=yes

make test-int TEST_ARGS="-k test_get_vpc_with_rdma_type"
make test-int TEST_ARGS="-k test_get_vpc"
make test-int TEST_ARGS="-k test_get_subnet_with_rdma_type"
make test-int TEST_ARGS="-k test_get_subnet"
make test-int TEST_ARGS="-k test_linode_interfaces_with_rdma_vpc_type"

* init * add unit test * lint * nit` * add explict reject * fix firewall id

* init * add unit test * lint * nit` * Add integration tests for RDMA VPC and Subnet * Update fixture and test assertions for RDMA VPC * Create fixture for subnet RDMA * Change rdma fixtures scope --------- Co-authored-by: Ye Chen <yechen@akamai.com>

Copilot

🟡 Changes recommended

Preserve VPC API compatibility and correctly gate RDMA tests while selecting an RDMA-capable region.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds GPUDirect RDMA support for VPCs and Linode interfaces across SDK models, APIs, fixtures, and tests.

Changes:

Adds RDMA VPC types, regional capability, and interface models.
Supports RDMA interfaces during instance creation.
Adds unit and integration coverage for RDMA resources.

File summaries

File	Description
`test/unit/objects/vpc_test.py`	Tests VPC type handling.
`test/unit/objects/linode_test.py`	Tests post-creation RDMA interface rejection.
`test/unit/objects/linode_interface_test.py`	Tests RDMA interface serialization and updates.
`test/unit/groups/linode_test.py`	Tests instance creation with RDMA interfaces.
`test/integration/models/vpc/test_vpc.py`	Tests RDMA VPC and subnet retrieval.
`test/integration/models/linode/interfaces/test_interfaces.py`	Tests RDMA-enabled Linode provisioning.
`test/integration/conftest.py`	Adds RDMA fixtures; test gating and capability-aware region selection need correction.
`test/fixtures/vpcs.json`	Adds VPC type fixture data.
`test/fixtures/vpcs_123456.json`	Adds VPC type fixture data.
`test/fixtures/vpcs_123456_subnets.json`	Adds subnet VPC type fixture data.
`test/fixtures/vpcs_123456_subnets_789.json`	Adds subnet VPC type fixture data.
`test/fixtures/linode_instances_124_interfaces_999.json`	Adds an RDMA interface response fixture.
`linode_api4/objects/vpc.py`	Defines VPC types and response properties.
`linode_api4/objects/region.py`	Adds the GPUDirect RDMA capability.
`linode_api4/objects/linode.py`	Rejects unsupported post-creation RDMA interfaces.
`linode_api4/objects/linode_interfaces.py`	Adds RDMA interface models; public interface-limit documentation needs updating.
`linode_api4/groups/vpc.py`	Adds VPC type creation support but breaks positional argument compatibility.

Review details

Suppressed comments (1)

linode_api4/objects/linode_interfaces.py:248

Exposing rdma_vpc enables the new flow that creates at least eight RDMA interfaces plus a regular interface, but LinodeGroup.instance_create still documents interfaces as limited to three (linode_api4/groups/linode.py:341-343). Update that public docstring to describe the RDMA-specific limit so SDK consumers are not told their supported configuration is invalid.

    rdma_vpc: Optional[LinodeInterfaceRDMAVPCOptions] = None

Files reviewed: 17/17 changed files
Comments generated: 3
Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

zliang-akamai · 2026-09-08T19:48:37Z

Some Copilot comments worth a look, and one minor comment about the test case, otherwise looks good to me!

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

🔵 Needs a closer look

The integration test region caching in test/integration/conftest.py is currently inconsistent/redundant and can lead to confusing or incorrect region reuse, so it should be made consistent before merging.

Review details

Suppressed comments (2)

Previously missed (2) — in code that hasn't changed since the last review.

test/integration/conftest.py:480

TEST_VPC_REGION is computed but the VPC itself is created using a separate get_region() call with a different capability set, so the cached region may not match the actual region used by this session fixture (and may be missing capabilities like Custom VPC IPv4 Ranges). Compute the region once, assign it to TEST_VPC_REGION, and reuse it for the create() call to keep region selection consistent and avoid redundant API calls.
test/integration/models/linode/interfaces/test_interfaces.py:104
The docstring has a couple of grammatical issues (missing article “an” and inconsistent capitalization of “Linode”). Tightening the wording makes the intent clearer for future readers.

Files reviewed: 17/17 changed files
Comments generated: 0 new
Review effort level: Lite

Copilot

🟢 Approval recommended

The changes add RDMA VPC/interface support with solid unit and integration coverage, and the remaining feedback is limited to small doc/comment clarity nits.

Review details

Suppressed comments (2)

Previously missed (2) — in code that hasn't changed since the last review.

linode_api4/groups/vpc.py:70

The docstring calls GPUDirect RDMA an "account capability", but this project’s Capability enum represents region capabilities (see Region.Capability). This wording is likely misleading for SDK users; consider referring to it as a region capability (or just "capability") to match the rest of the codebase.
test/integration/models/linode/interfaces/test_interfaces.py:104
Docstring grammar: "may be needed for RDMA Linode instance" is missing an article, and "linode" should be capitalized for the product name used elsewhere in this file.

Files reviewed: 17/17 changed files
Comments generated: 1
Review effort level: Lite

yec-akamai and others added 5 commits July 6, 2026 11:40

TPT-4462: Support VPC RDMA Interfaces (#711)

017b450

* init * add unit test * lint * nit` * add explict reject * fix firewall id

Add test for RDMA Linode instance creation (#733)

7b919ab

Merge branch 'dev' into proj/rdma-interfaces

ab96006

enable int test

3eaebe4

yec-akamai added the project for new projects in the changelog. label Sep 2, 2026

yec-akamai requested review from a team as code owners September 2, 2026 15:59

yec-akamai requested review from psnoch-akamai and zliang-akamai and removed request for a team September 2, 2026 15:59

zliang-akamai requested a balanced review from Copilot September 8, 2026 19:39

Copilot started reviewing on behalf of zliang-akamai September 8, 2026 19:39 View session

Copilot AI reviewed Sep 8, 2026

View reviewed changes

Comment thread linode_api4/groups/vpc.py Outdated

Comment thread test/integration/conftest.py

Comment thread test/integration/conftest.py Outdated

zliang-akamai reviewed Sep 8, 2026

View reviewed changes

Comment thread test/integration/models/linode/interfaces/test_interfaces.py

zliang-akamai previously approved these changes Sep 8, 2026

View reviewed changes

Fix formatting of vpc_type parameter in vpc.py

af89f2c

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

yec-akamai dismissed zliang-akamai’s stale review via af89f2c September 8, 2026 19:55

zliang-akamai requested a lite review from Copilot September 8, 2026 20:07

zliang-akamai previously approved these changes Sep 8, 2026

View reviewed changes

Copilot started reviewing on behalf of zliang-akamai September 8, 2026 20:08 View session

Copilot AI reviewed Sep 8, 2026

View reviewed changes

ezilber-akamai previously approved these changes Sep 8, 2026

View reviewed changes

zliang-akamai reviewed Sep 8, 2026

View reviewed changes

Comment thread test/integration/conftest.py Outdated

improve test

16e1eb6

yec-akamai dismissed stale reviews from ezilber-akamai and zliang-akamai via 16e1eb6 September 8, 2026 20:31

zliang-akamai approved these changes Sep 8, 2026

View reviewed changes

zliang-akamai requested a lite review from Copilot September 8, 2026 20:32

Copilot started reviewing on behalf of zliang-akamai September 8, 2026 20:33 View session

Copilot AI reviewed Sep 8, 2026

View reviewed changes

Comment thread test/integration/conftest.py

ezilber-akamai approved these changes Sep 8, 2026

View reviewed changes

yec-akamai merged commit 7e8b20c into dev Sep 8, 2026
14 checks passed

Navigation Menu

Uh oh!

TPT-4456: Project RDMA Linode Interfaces - #736

TPT-4456: Project RDMA Linode Interfaces#736
yec-akamai merged 7 commits into
devfrom
proj/rdma-interfaces

yec-akamai commented Sep 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zliang-akamai commented Sep 8, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

yec-akamai commented Sep 2, 2026

📝 Description

✔️ How to Test

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Suppressed comments (1)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zliang-akamai commented Sep 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Suppressed comments (2)

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Suppressed comments (2)

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants